Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which scala version is used? Contradictory information reported at command line. #854

Merged
merged 2 commits into from Apr 8, 2013

Conversation

huntc
Copy link
Contributor

@huntc huntc commented Mar 15, 2013

I edited project/Build.scala, setting Keys.scalaVersion := "2.10.1" . Now when I fire up play, it still tells me it is using ... Scala 2.10.0, but then scala-version will report 2.10.1. What is the meaning of this?

$play
[info] blahblah
       _            _
 _ __ | | __ _ _  _| |
| '_ \| |/ _' | || |_|
|  __/|_|\____|\__ (_)
|_|            |__/

play! 2.1.0 (using Java 1.6.0_43 and Scala 2.10.0), http://www.playframework.org

> Type "help play" or "license" for more information.
> Type "exit" or use Ctrl+D to leave this console.

[dev_portal] $ scala-version
[info] 2.10.1

@Gissues:{"order":99.21875,"status":"inprogress"}

@huntc
Copy link
Contributor

huntc commented Mar 15, 2013

That does appear a little confusing. The Java version is picked up by calling System.getProperty("java.version") yet the Scala version is picked up via play.core.PlayVersion.scalaVersion (a constant that we define which represents the default version of Scala).

I shall look at changing the console output to pick up the actual Scala version being used at runtime.

@ghost ghost assigned huntc Mar 15, 2013
…a being used at runtime - to be consistent with the reporting of the Java runtime. Fixes issue playframework#854
@huntc
Copy link
Contributor

huntc commented Mar 15, 2013

@DanBurton are you in a position to test out my pull request and see if my change works for you?

@DanBurton
Copy link
Author

@huntc Okay, I cloned the repo, and copy/pasted the change (yeah I'm a git newb like that..). It didn't do what I expected. Now I'm getting this:

       _            _
 _ __ | | __ _ _  _| |
| '_ \| |/ _' | || |_|
|  __/|_|\____|\__ (_)
|_|            |__/

play! 2.2-SNAPSHOT (using Java 1.6.0_43 and Scala 2.9.2), http://www.playframework.com

> Type "help play" or "license" for more information.
> Type "exit" or use Ctrl+D to leave this console.

[test-scala-version] $ scala-version
[info] 2.10.1

Scala 2.9.2. Not sure where that came from.

@huntc
Copy link
Contributor

huntc commented Mar 19, 2013

The Scala version reported is the one that Play itself has as a runtime. This is consistent with the reporting if the Java version.

@huntc huntc closed this Mar 19, 2013
@huntc huntc reopened this Mar 19, 2013
@unoexperto
Copy link

I'm on Play 2.1.1-RC2. I agree that this message is misleading.

@huntc
Copy link
Contributor

huntc commented Apr 8, 2013

The information now reported is something like:

play! 2.2-SNAPSHOT built with Scala 2.10.0 (running Java 1.7.0_12-ea), http://www.playframework.com

i.e. clarity to the meaning of the values being reported has been added.

@jroper can you please review/merge as appropriate?

jroper added a commit that referenced this pull request Apr 8, 2013
Which scala version is used? Contradictory information reported at command line.
@jroper jroper merged commit 3ebf599 into playframework:master Apr 8, 2013
@cloudbees-pull-request-builder

play2-master-PRs #14 SUCCESS
This pull request looks good

@huntc huntc deleted the scala-version-runtime-report branch April 10, 2013 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants