-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which scala version is used? Contradictory information reported at command line. #854
Which scala version is used? Contradictory information reported at command line. #854
Conversation
That does appear a little confusing. The Java version is picked up by calling System.getProperty("java.version") yet the Scala version is picked up via play.core.PlayVersion.scalaVersion (a constant that we define which represents the default version of Scala). I shall look at changing the console output to pick up the actual Scala version being used at runtime. |
…a being used at runtime - to be consistent with the reporting of the Java runtime. Fixes issue playframework#854
@DanBurton are you in a position to test out my pull request and see if my change works for you? |
@huntc Okay, I cloned the repo, and copy/pasted the change (yeah I'm a git newb like that..). It didn't do what I expected. Now I'm getting this:
Scala 2.9.2. Not sure where that came from. |
The Scala version reported is the one that Play itself has as a runtime. This is consistent with the reporting if the Java version. |
I'm on Play 2.1.1-RC2. I agree that this message is misleading. |
The information now reported is something like: play! 2.2-SNAPSHOT built with Scala 2.10.0 (running Java 1.7.0_12-ea), http://www.playframework.com i.e. clarity to the meaning of the values being reported has been added. @jroper can you please review/merge as appropriate? |
Which scala version is used? Contradictory information reported at command line.
play2-master-PRs #14 SUCCESS |
I edited
project/Build.scala
, settingKeys.scalaVersion := "2.10.1"
. Now when I fire upplay
, it still tells me it isusing ... Scala 2.10.0
, but thenscala-version
will report2.10.1
. What is the meaning of this?@Gissues:{"order":99.21875,"status":"inprogress"}